Use Extended DDP Packets for NBP Lookup Requests On LocalTalk#2
Open
NJRoadfan wants to merge 5 commits intolampmerchant:mainfrom
Open
Use Extended DDP Packets for NBP Lookup Requests On LocalTalk#2NJRoadfan wants to merge 5 commits intolampmerchant:mainfrom
NJRoadfan wants to merge 5 commits intolampmerchant:mainfrom
Conversation
When broadcasting NBP multicast packets on a non-extended network (LocalTalk), use the network's number in broadcasts. When it is an extended network (EtherTalk), use "0". This mirrors the behavior of commercial AppleTalk routers such as the Shiva Fastpath. It also avoids annoying behavior with the ImageWriter LocalTalk Option card. That card will unconditionally send back NBP responses to the initial requestor's address (in this case, TashRouter) if using short DDP packets, not the destination in the NBP tuple.
Author
|
My informal testing shows this as working. This PR needs to be tested against the ImageWriter LocalTalk card. It also needs verification that it is sending packets to "0.255" in all cases on EtherTalk networks. |
NJRoadfan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When broadcasting NBP multicast packets on a non-extended network (LocalTalk), use the network's number in broadcasts. When it is an extended network (EtherTalk), use "0". This mirrors the behavior of commercial AppleTalk routers such as the Shiva Fastpath.
It also avoids annoying behavior with the ImageWriter LocalTalk Option card. That card will unconditionally send back NBP responses to the initial requestor's address (in this case, TashRouter) if using short DDP packets for lookups, not the destination in the NBP tuple.